Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e(upgrades): ordered ICA channel can be closed after upgrade and packet timeout #5537

Merged
merged 14 commits into from
Jan 29, 2024
Merged

e2e(upgrades): ordered ICA channel can be closed after upgrade and packet timeout #5537

merged 14 commits into from
Jan 29, 2024

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Jan 8, 2024 •
edited
Loading

Description

closes: #5538

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@crodriguezvega crodriguezvega added e2e channel-upgradability Channel upgradability feature labels Jan 8, 2024
@crodriguezvega crodriguezvega marked this pull request as ready for review January 16, 2024 08:06
@crodriguezvega crodriguezvega added the priority PRs that need prompt reviews label Jan 16, 2024
DimitrisJim
DimitrisJim approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, left one comment re re-using some functions which you probably also noticed.

e2e/tests/interchain_accounts/upgrades_test.go Show resolved Hide resolved
@DimitrisJim
Copy link
Contributor

also note same e2e is failing for other PRs, seems like a regression someplace (relayer?)

@crodriguezvega
Copy link
Contributor Author

also note same e2e is failing for other PRs, seems like a regression someplace (relayer?)

I will take a look.

@DimitrisJim DimitrisJim mentioned this pull request Jan 16, 2024
Closed
3 tasks
@crodriguezvega
Copy link
Contributor Author

Looks like in the failing tests the relayer is submitting TRY twice to chain B. I already let Luca know.

@colin-axner colin-axner mentioned this pull request Jan 17, 2024
Closed
3 tasks
@damiannolan
Copy link
Member

Is this the PR that requires a new relayer image before merging? I see the test is still failing in CI

@crodriguezvega
Copy link
Contributor Author

Is this the PR that requires a new relayer image before merging? I see the test is still failing in CI

Correct. Got a new image yesterday, but fails (even though it was passing with the previous image). Already let Luca know.

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (310a4bd) 81.49% compared to head (aae7e0f) 81.51%.
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5537      +/-   ##
==========================================
+ Coverage   81.49%   81.51%   +0.02%     
==========================================
  Files         199      199              
  Lines       15203    15225      +22     
==========================================
+ Hits        12389    12411      +22     
  Misses       2348     2348              
  Partials      466      466
Files Coverage Δ
modules/core/04-channel/keeper/keeper.go 90.84% <100.00%> (+0.06%) ⬆️
modules/core/04-channel/keeper/upgrade.go 92.52% <100.00%> (+0.21%) ⬆️

colin-axner
colin-axner approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @crodriguezvega for all your works getting the e2e's to be green!!!! ❤️‍🔥

e2e/tests/interchain_accounts/upgrades_test.go Outdated Show resolved Hide resolved
Carlos Rodriguez and others added 2 commits January 29, 2024 15:09
@colin-axner
Update e2e/tests/interchain_accounts/upgrades_test.go
3f7ac92 
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Merge branch 'main' into carlos/ica-channel-timeout-after-upgrade
149d0a7
@crodriguezvega crodriguezvega merged commit 9a00ffe into main Jan 29, 2024
65 checks passed
@crodriguezvega crodriguezvega deleted the carlos/ica-channel-timeout-after-upgrade branch January 29, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@colin-axner colin-axner colin-axner approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@charleenfei charleenfei Awaiting requested review from charleenfei

@damiannolan damiannolan Awaiting requested review from damiannolan

@chatton chatton Awaiting requested review from chatton

Assignees
No one assigned
Labels
channel-upgradability Channel upgradability feature e2e priority PRs that need prompt reviews
Projects
None yet
Milestone
No milestone
5 participants
@crodriguezvega @DimitrisJim @damiannolan @codecov-commenter @colin-axner